feat(404): add 404 page with i18n support#9
Merged
Conversation
|
@ramistodev is attempting to deploy a commit to the midudev pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a localized custom 404 error page and improves translation consistency in the codebase. The main changes include implementing a new
404.astropage with i18n support, introducing new translation keys for the 404 page in both English and Spanish, and standardizing translation object keys for better maintainability.404 Page Implementation:
src/pages/404.astrocomponent to render a user-friendly, localized 404 error page. The page displays translated titles, descriptions, and a "Back to home" button based on the user's locale.Internationalization Enhancements:
notFoundTitle,notFoundDescription,backToHome) for both English and Spanish insrc/i18n/translations.tsto support the 404 page. [1] [2] [3]'recursion'→recursion) for improved code consistency and maintainability in both English and Spanish translations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Minor Code Improvements:
getAlgorithmMetaTitlefunction signature for readability insrc/i18n/translations.ts.